mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: override fs.realpathSync.native and fs.realpath.native (#14031)

Browse source 
* fix: override fs.realpathSync.native and fs.realpath.native
* spec: test new native functions
This commit is contained in:
Shelley Vohr 2018-08-12 00:10:55 -07:00 • committed by GitHub
parent 8dae1c8447
commit b785f45852
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 228 additions and 82 deletions
Download patch file Download diff file Expand all files Collapse all files

69
lib/common/asar.js
View file

@ -332,43 +332,68 @@
const {realpathSync} = fs
fs.realpathSync = function (p) {
const [isAsar, asarPath, filePath] = splitPath(p)
if (!isAsar) {
return realpathSync.apply(this, arguments)
}
if (!isAsar) return realpathSync.apply(this, arguments)
const archive = getOrCreateArchive(asarPath)
if (!archive) {
invalidArchiveError(asarPath)
}
if (!archive) return invalidArchiveError(asarPath)
const real = archive.realpath(filePath)
if (real === false) {
notFoundError(asarPath, filePath)
}
if (real === false) notFoundError(asarPath, filePath)
return path.join(realpathSync(asarPath), real)
}
fs.realpathSync.native = function (p) {
const [isAsar, asarPath, filePath] = splitPath(p)
if (!isAsar) return realpathSync.native.apply(this, arguments)
const archive = getOrCreateArchive(asarPath)
if (!archive) return invalidArchiveError(asarPath)
const real = archive.realpath(filePath)
if (real === false) notFoundError(asarPath, filePath)
return path.join(realpathSync.native(asarPath), real)
}
const {realpath} = fs
fs.realpath = function (p, cache, callback) {
const [isAsar, asarPath, filePath] = splitPath(p)
if (!isAsar) {
return realpath.apply(this, arguments)
}
if (!isAsar) return realpath.apply(this, arguments)
if (typeof cache === 'function') {
callback = cache
cache = void 0
}
const archive = getOrCreateArchive(asarPath)
if (!archive) {
return invalidArchiveError(asarPath, callback)
}
if (!archive) return invalidArchiveError(asarPath, callback)
const real = archive.realpath(filePath)
if (real === false) {
return notFoundError(asarPath, filePath, callback)
if (real === false) return notFoundError(asarPath, filePath, callback)
return realpath(asarPath, (err, p) => {
return (err) ? callback(err) : callback(null, path.join(p, real))
})
}
fs.realpath.native = function (p, cache, callback) {
const [isAsar, asarPath, filePath] = splitPath(p)
if (!isAsar) return realpath.native.apply(this, arguments)
if (typeof cache === 'function') {
callback = cache
cache = void 0
}
return realpath(asarPath, function (err, p) {
if (err) {
return callback(err)
}
return callback(null, path.join(p, real))
const archive = getOrCreateArchive(asarPath)
if (!archive) return invalidArchiveError(asarPath, callback)
const real = archive.realpath(filePath)
if (real === false) return notFoundError(asarPath, filePath, callback)
return realpath.native(asarPath, (err, p) => {
return (err) ? callback(err) : callback(null, path.join(p, real))
})
}