mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

feat: disable the remote module by default (#22091)

Browse source
This commit is contained in:
Jeremy Apthorp 2020-02-10 10:49:09 -08:00 • committed by GitHub
parent af631f8204
commit b77f701aeb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
8 changed files with 62 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

26
spec-main/api-browser-window-spec.ts
View file

@ -1628,6 +1628,7 @@ describe('BrowserWindow module', () => {
show: false,
webPreferences: {
nodeIntegration: true,
enableRemoteModule: true,
preload
}
})
@ -1749,7 +1750,7 @@ describe('BrowserWindow module', () => {
describe(description, () => {
const preload = path.join(__dirname, 'fixtures', 'module', 'preload-remote.js')
it('enables the remote module by default', async () => {
it('disables the remote module by default', async () => {
const w = new BrowserWindow({
show: false,
webPreferences: {
@ -1760,7 +1761,7 @@ describe('BrowserWindow module', () => {
const p = emittedOnce(ipcMain, 'remote')
w.loadFile(path.join(fixtures, 'api', 'blank.html'))
const [, remote] = await p
expect(remote).to.equal('object')
expect(remote).to.equal('undefined')
})
it('disables the remote module when false', async () => {
@ -1777,6 +1778,21 @@ describe('BrowserWindow module', () => {
const [, remote] = await p
expect(remote).to.equal('undefined')
})
it('enables the remote module when true', async () => {
const w = new BrowserWindow({
show: false,
webPreferences: {
preload,
sandbox,
enableRemoteModule: true
}
})
const p = emittedOnce(ipcMain, 'remote')
w.loadFile(path.join(fixtures, 'api', 'blank.html'))
const [, remote] = await p
expect(remote).to.equal('object')
})
})
}
@ -2093,7 +2109,8 @@ describe('BrowserWindow module', () => {
show: false,
webPreferences: {
preload,
sandbox: true
sandbox: true,
enableRemoteModule: true
}
})
w.loadFile(path.join(__dirname, 'fixtures', 'api', 'sandbox.html'), { search: 'reload-remote' })
@ -2125,7 +2142,8 @@ describe('BrowserWindow module', () => {
show: false,
webPreferences: {
preload,
sandbox: true
sandbox: true,
enableRemoteModule: true
}
})
w.webContents.once('new-window', (event, url, frameName, disposition, options) => {