mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Add better comments to ShouldCreateNewSiteInstance

Browse source
This commit is contained in:
Ryohei Ikegami 2017-04-05 18:16:10 +09:00
parent cbdd52e43b
commit b683584859
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
atom/browser/atom_browser_client.cc
View file

@ -105,8 +105,10 @@ bool AtomBrowserClient::ShouldCreateNewSiteInstance(
auto web_contents =
content::WebContents::FromRenderFrameHost(render_frame_host);
if (root_web_contents_.find(web_contents) != root_web_contents_.end()) {
// non-sandboxed renderers with native.window.open always create a new
// SiteInstance in the root webcontents.
// Root WebContents should always create new process
// to make sure native addons are loaded correctly after reload / navigation.
// (Non-root WebContents opened by window.open() should try to reuse process
// to allow synchronous cross-window scripting.)
return true;
}
}