From b647c8935db71b0644392a02619019963850fe5a Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Sat, 29 Mar 2025 08:12:15 -0500 Subject: [PATCH] perf: avoid 3x call to `GetID()` in RegisterPendingSiteInstance() (#46359) perf: avoid 3x call to GetID() in RegisterPendingSiteInstance() Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr --- shell/browser/electron_browser_client.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/shell/browser/electron_browser_client.cc b/shell/browser/electron_browser_client.cc index 2766dc7b4e7c..510963b8f8bb 100644 --- a/shell/browser/electron_browser_client.cc +++ b/shell/browser/electron_browser_client.cc @@ -446,13 +446,13 @@ void ElectronBrowserClient::RegisterPendingSiteInstance( content::SiteInstance* pending_site_instance) { // Remember the original web contents for the pending renderer process. auto* web_contents = content::WebContents::FromRenderFrameHost(rfh); - auto* pending_process = pending_site_instance->GetProcess(); - pending_processes_[pending_process->GetID()] = web_contents; + const auto pending_process_id = pending_site_instance->GetProcess()->GetID(); + pending_processes_[pending_process_id] = web_contents; if (rfh->GetParent()) - renderer_is_subframe_.insert(pending_process->GetID()); + renderer_is_subframe_.insert(pending_process_id); else - renderer_is_subframe_.erase(pending_process->GetID()); + renderer_is_subframe_.erase(pending_process_id); } void ElectronBrowserClient::AppendExtraCommandLineSwitches(