mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: crash when navigating from a page with webview that has inherited zoom level (#24757)

Browse source 
* fix: cleanup webview zoom level observers on navigation

* add spec

* webview should be on same partition

* wait for webview to finish loading
This commit is contained in:
Robo 2020-07-28 13:00:44 -07:00 • committed by GitHub
parent 38fafe4986
commit b6321cc22d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 41 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
shell/browser/web_view_guest_delegate.cc
View file

@ -57,6 +57,10 @@ void WebViewGuestDelegate::AttachToIframe(
api_web_contents_->Emit("did-attach");
}
void WebViewGuestDelegate::WillDestroy() {
ResetZoomController();
}
void WebViewGuestDelegate::DidDetach() {
ResetZoomController();
}