From b5b49c9ed0bc7116cd8c9db5e8b3f69c5fd9b402 Mon Sep 17 00:00:00 2001 From: deepak1556 Date: Thu, 25 Oct 2018 22:29:38 +0530 Subject: [PATCH] FIXME: Remove SchemeRegistry::RegisterURLSchemeAsCORSEnabled https://chromium-review.googlesource.com/c/chromium/src/+/1157364 --- atom/renderer/api/atom_api_web_frame.cc | 4 +++- atom/renderer/renderer_client_base.cc | 1 - 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/atom/renderer/api/atom_api_web_frame.cc b/atom/renderer/api/atom_api_web_frame.cc index 873575a6030..24628dc00fe 100644 --- a/atom/renderer/api/atom_api_web_frame.cc +++ b/atom/renderer/api/atom_api_web_frame.cc @@ -276,7 +276,9 @@ void WebFrame::RegisterURLSchemeAsPrivileged(const std::string& scheme, privileged_scheme); } if (corsEnabled) { - blink::SchemeRegistry::RegisterURLSchemeAsCORSEnabled(privileged_scheme); + // FIXME: blink::SchemeRegistry::RegisterURLSchemeAsCORSEnabled + // is removed with C70 + // https://chromium-review.googlesource.com/c/chromium/src/+/1157364 } } diff --git a/atom/renderer/renderer_client_base.cc b/atom/renderer/renderer_client_base.cc index 9b26cc7dca4..fae80e78e7e 100644 --- a/atom/renderer/renderer_client_base.cc +++ b/atom/renderer/renderer_client_base.cc @@ -153,7 +153,6 @@ void RendererClientBase::RenderThreadStarted() { // In Chrome we should set extension's origins to match the pages they can // work on, but in Electron currently we just let extensions do anything. blink::SchemeRegistry::RegisterURLSchemeAsSecure(extension_scheme); - blink::SchemeRegistry::RegisterURLSchemeAsCORSEnabled(extension_scheme); blink::SchemeRegistry::RegisterURLSchemeAsBypassingContentSecurityPolicy( extension_scheme);