mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

avoid using eslint comment exceptions

Browse source
This commit is contained in:
Zeke Sikelianos 2016-03-30 14:06:50 -07:00 • committed by Kevin Sawicki
parent 1a18151eff
commit b5afad9da7
5 changed files with 10 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

6
spec/api-browser-window-spec.js
View file

@ -759,19 +759,19 @@ describe('browser-window module', function () {
describe('deprecated options', function () {
it('throws a deprecation error for option keys using hyphens instead of camel case', function () {
assert.throws(function () {
new BrowserWindow({'min-width': 500}) // eslint-disable-line
return new BrowserWindow({'min-width': 500})
}, 'min-width is deprecated. Use minWidth instead.')
})
it('throws a deprecation error for webPreference keys using hyphens instead of camel case', function () {
assert.throws(function () {
new BrowserWindow({webPreferences: {'node-integration': false}}) // eslint-disable-line
return new BrowserWindow({webPreferences: {'node-integration': false}})
}, 'node-integration is deprecated. Use nodeIntegration instead.')
})
it('throws a deprecation error for option keys that should be set on webPreferences', function () {
assert.throws(function () {
new BrowserWindow({zoomFactor: 1}) // eslint-disable-line
return new BrowserWindow({zoomFactor: 1})
}, 'options.zoomFactor is deprecated. Use options.webPreferences.zoomFactor instead.')
})
})