From c562b24df8c53b091753c20cfb9ca82360b39a1d Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Tue, 5 Apr 2016 17:08:27 +0900 Subject: [PATCH 1/3] spec: Add test case for #5028 --- spec/node-spec.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/spec/node-spec.js b/spec/node-spec.js index 286c4d6f9161..c5c26196769d 100644 --- a/spec/node-spec.js +++ b/spec/node-spec.js @@ -196,6 +196,11 @@ describe('node feature', function () { assert.equal(b.toString(), 'Jøhänñéß') assert.equal(Buffer.byteLength(p.innerText), 13) }) + + it('does not crash when creating large Buffers', function () { + new Buffer(new Array(4096).join(' ')); + new Buffer(new Array(4097).join(' ')); + }) }) describe('process.stdout', function () { From 7796dbb7cedbf6822fba97c2aafbb62d0adf22d3 Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Tue, 5 Apr 2016 17:30:18 +0900 Subject: [PATCH 2/3] Update node: rebase on v5.10.0 tag instead of master branch --- vendor/node | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vendor/node b/vendor/node index 95e76436b3ac..c18d608cd584 160000 --- a/vendor/node +++ b/vendor/node @@ -1 +1 @@ -Subproject commit 95e76436b3aceff54ebf8b32282cdbf8c74c4a5a +Subproject commit c18d608cd584e6b1c94a5d0d89939a1457f589b0 From dd283ff8d7c54a79a528114a881376af30598448 Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Tue, 5 Apr 2016 19:53:07 +0900 Subject: [PATCH 3/3] spec: We should not use pre release of Node --- spec/node-spec.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/spec/node-spec.js b/spec/node-spec.js index c5c26196769d..0ab98aa67ab9 100644 --- a/spec/node-spec.js +++ b/spec/node-spec.js @@ -217,6 +217,12 @@ describe('node feature', function () { }) }) + describe('process.version', function () { + it('should not have -pre', function () { + assert(!process.version.endsWith('-pre')) + }) + }) + describe('vm.createContext', function () { it('should not crash', function () { require('vm').runInNewContext('')