mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

return bool on shell.openExternal

Browse source
This commit is contained in:
msullivan 2015-06-10 11:06:22 -04:00
parent 8aa815e6d1
commit b4674923c9
4 changed files with 23 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

13
atom/common/platform_util_mac.mm
View file

@ -118,12 +118,19 @@ void OpenItem(const base::FilePath& full_path) {
}
}
void OpenExternal(const GURL& url) {
bool OpenExternal(const GURL& url) {
DCHECK([NSThread isMainThread]);
NSString* url_string = base::SysUTF8ToNSString(url.spec());
NSURL* ns_url = [NSURL URLWithString:url_string];
if (!ns_url || ![[NSWorkspace sharedWorkspace] openURL:ns_url])
LOG(WARNING) << "NSWorkspace failed to open URL " << url;
if (!ns_url){
return false;
}
NSArray *appUrls = (NSArray*)LSCopyApplicationURLsForURL((CFURLRef)ns_url, kLSRolesAll);
if([appUrls count] > 0){
if([[NSWorkspace sharedWorkspace] openURL:ns_url])
return true;
}
return false;
}
bool MoveItemToTrash(const base::FilePath& full_path) {