ci: fix breakpad symbols generation (#14981)

This commit is contained in:
Alexey Kuzmin 2018-10-06 01:55:06 +02:00 committed by GitHub
parent 5eeff55e83
commit b45dc78751
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 2 deletions

View file

@ -287,7 +287,7 @@ step-mksnapshot-store: &step-mksnapshot-store
path: src/out/Default/mksnapshot.zip
destination: mksnapshot.zip
step-generate-breakpad_symbols: &step-generate-breakpad_symbols
step-generate-breakpad-symbols: &step-generate-breakpad-symbols
run:
name: Generate breakpad symbols
command: |
@ -295,6 +295,9 @@ step-generate-breakpad_symbols: &step-generate-breakpad_symbols
# Build needed dump_syms executable
ninja -C out/Default third_party/breakpad:dump_syms
electron/script/dump-symbols.py -d "$PWD/out/Default/electron.breakpad.syms"
# TODO(alexeykuzmin): Explicitly pass an out folder path to the "zip-symbols.py" script.
export ELECTRON_OUT_DIR=Default
electron/script/zip-symbols.py
step-maybe-native-mksnapshot-gn-gen: &step-maybe-native-mksnapshot-gn-gen
@ -415,6 +418,10 @@ steps-electron-build-for-tests: &steps-electron-build-for-tests
# Save all data needed for a further tests run.
- *step-persist-data-for-tests
# Breakpad symbols.
# TODO(alexeykuzmin): We should do it only in nightly builds.
- *step-generate-breakpad-symbols
# Trigger tests on arm hardware if needed
- *step-maybe-trigger-arm-test
@ -433,7 +440,7 @@ steps-electron-build-for-publish: &steps-electron-build-for-publish
- *step-electron-build
- *step-electron-dist-build
- *step-electron-dist-store
- *step-generate-breakpad_symbols
- *step-generate-breakpad-symbols
# mksnapshot
- *step-mksnapshot-build

View file

@ -72,6 +72,9 @@ jobs:
# Build needed dump_syms executable
ninja -C out/Default third_party/breakpad:dump_syms
electron/script/dump-symbols.py -d "$PWD/out/Default/electron.breakpad.syms"
# TODO(alexeykuzmin): Explicitly pass an out folder path to the "zip-symbols.py" script.
export ELECTRON_OUT_DIR=Default
electron/script/zip-symbols.py
displayName: Ninja build app
condition: and(succeeded(), eq(variables['ELECTRON_RELEASE'], '1'))