mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

add deprecation notices to webframe

Browse source
This commit is contained in:
Paul Frazee 2016-11-14 12:33:30 -06:00 • committed by Kevin Sawicki
parent 99ea50649a
commit b458201874
2 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
atom/renderer/api/atom_api_web_frame.cc
View file

@ -133,6 +133,7 @@ void WebFrame::SetSpellCheckProvider(mate::Arguments* args,
} }
void WebFrame::RegisterURLSchemeAsSecure(const std::string& scheme) { void WebFrame::RegisterURLSchemeAsSecure(const std::string& scheme) {
// TODO(pfrazee): Remove 2.0
// Register scheme to secure list (https, wss, data). // Register scheme to secure list (https, wss, data).
blink::WebSecurityPolicy::registerURLSchemeAsSecure( blink::WebSecurityPolicy::registerURLSchemeAsSecure(
blink::WebString::fromUTF8(scheme)); blink::WebString::fromUTF8(scheme));
@ -165,6 +166,7 @@ void WebFrame::RegisterURLSchemeAsPrivileged(const std::string& scheme,
// Register scheme to privileged list (https, wss, data, chrome-extension) // Register scheme to privileged list (https, wss, data, chrome-extension)
blink::WebString privileged_scheme(blink::WebString::fromUTF8(scheme)); blink::WebString privileged_scheme(blink::WebString::fromUTF8(scheme));
if (secure) { if (secure) {
// TODO(pfrazee): Remove 2.0
blink::WebSecurityPolicy::registerURLSchemeAsSecure(privileged_scheme); blink::WebSecurityPolicy::registerURLSchemeAsSecure(privileged_scheme);
} }
if (bypassCSP) { if (bypassCSP) {

10
docs/tutorial/planned-breaking-changes.md
View file

@ -117,6 +117,16 @@ webContents.setVisualZoomLevelLimits(1, 2)
webFrame.setZoomLevelLimits(1, 2) webFrame.setZoomLevelLimits(1, 2)
// Replace with // Replace with
webFrame.setVisualZoomLevelLimits(1, 2) webFrame.setVisualZoomLevelLimits(1, 2)
// Deprecated
webFrame.registerURLSchemeAsSecure('app')
// Replace with
protocol.registerStandardSchemes('app', {secure: true})
// Deprecated
webFrame.registerURLSchemeAsPrivileged('app', {secure: true})
// Replace with
protocol.registerStandardSchemes('app', {secure: true})
``` ```
## `<webview>` ## `<webview>`