mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Fixing code review issues: adding a partition options and making the session option only takes Session objects.

Browse source
This commit is contained in:
ali.ibrahim 2016-10-25 15:47:54 +02:00
parent 6d7f179a9b
commit b44d5290e2
4 changed files with 40 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

8
spec/api-net-spec.js
View file

@ -797,10 +797,10 @@ describe('net module', function () {
urlRequest.end()
})
it('should to able to create and intercept a request on a custom session', function (done) {
it('should to able to create and intercept a request using a custom parition name', function (done) {
const requestUrl = '/requestUrl'
const redirectUrl = '/redirectUrl'
const customSessionName = 'custom-session'
const customPartitionName = 'custom-partition'
let requestIsRedirected = false
server.on('request', function (request, response) {
switch (request.url) {
@ -821,7 +821,7 @@ describe('net module', function () {
assert(false, 'Request should not be intercepted by the default session')
})
let customSession = session.fromPartition(customSessionName, {
let customSession = session.fromPartition(customPartitionName, {
cache: false
})
let requestIsIntercepted = false
@ -841,7 +841,7 @@ describe('net module', function () {
const urlRequest = net.request({
url: `${server.url}${requestUrl}`,
session: customSessionName
partition: customPartitionName
})
urlRequest.on('response', function (response) {
assert.equal(response.statusCode, 200)