mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Fixing code review issues: adding a partition options and making the session option only takes Session objects.

Browse source
This commit is contained in:
ali.ibrahim 2016-10-25 15:47:54 +02:00
parent 6d7f179a9b
commit b44d5290e2
4 changed files with 40 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

17
atom/browser/api/atom_api_url_request.cc
View file

@ -175,16 +175,21 @@ URLRequest::~URLRequest() {
mate::WrappableBase* URLRequest::New(mate::Arguments* args) {
v8::Local<v8::Object> options;
args->GetNext(&options);
mate::Dictionary dict(args->isolate(), options);
auto isolate = args->isolate();
mate::Dictionary dict(isolate, options);
std::string method;
dict.Get("method", &method);
std::string url;
dict.Get("url", &url);
std::string session_name;
dict.Get("session", &session_name);
auto session = Session::FromPartition(args->isolate(), session_name);
std::string partition;
mate::Handle<api::Session> session;
if (dict.Get("session", &session)) {
} else if (dict.Get("partition", &partition)) {
session = Session::FromPartition(isolate, partition);
} else {
// Use the default session if not specified.
session = Session::FromPartition(isolate, "");
}
auto browser_context = session->browser_context();
auto api_url_request = new URLRequest(args->isolate(), args->GetThis());
auto atom_url_request =