From b44892e27c337e2b146298f2345789497d47ce8f Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Sat, 5 Apr 2025 10:45:07 -0500 Subject: [PATCH] refactor: instantiate `navigation_entries` local variable on the stack (#46503) * refactor: instantiate navigation_entries on the stack instead of the heap Co-authored-by: Charles Kerr * refactor: reserve the full size of navigation_entries Co-authored-by: Charles Kerr * refactor: use emplace_back to simplify the code a little Co-authored-by: Charles Kerr --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr --- shell/browser/api/electron_api_web_contents.cc | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/shell/browser/api/electron_api_web_contents.cc b/shell/browser/api/electron_api_web_contents.cc index 4fc3ebbfc5b2..f84b8847806c 100644 --- a/shell/browser/api/electron_api_web_contents.cc +++ b/shell/browser/api/electron_api_web_contents.cc @@ -2609,8 +2609,9 @@ void WebContents::RestoreHistory( return; } - auto navigation_entries = std::make_unique< - std::vector>>(); + auto navigation_entries = + std::vector>{}; + navigation_entries.reserve(entries.size()); blink::UserAgentOverride ua_override; ua_override.ua_string_override = GetUserAgent(); @@ -2630,14 +2631,13 @@ void WebContents::RestoreHistory( nav_entry->SetIsOverridingUserAgent( !ua_override.ua_string_override.empty()); - navigation_entries->push_back( - std::unique_ptr(nav_entry)); + navigation_entries.emplace_back(nav_entry); } - if (!navigation_entries->empty()) { + if (!navigation_entries.empty()) { web_contents()->SetUserAgentOverride(ua_override, false); web_contents()->GetController().Restore( - index, content::RestoreType::kRestored, navigation_entries.get()); + index, content::RestoreType::kRestored, &navigation_entries); web_contents()->GetController().LoadIfNecessary(); } }