mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

filename as Optional argument

Browse source
This commit is contained in:
Pierre Laurac 2016-10-13 08:20:47 -07:00 • committed by Kevin Sawicki
parent 9736dc3115
commit b44371f4bf
3 changed files with 10 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
atom/browser/api/atom_api_window.cc
View file

@ -729,8 +729,11 @@ void Window::SetAspectRatio(double aspect_ratio, mate::Arguments* args) {
window_->SetAspectRatio(aspect_ratio, extra_size);
}
void Window::PreviewFile(const std::string& filepath,
const std::string& filename) {
void Window::PreviewFile(const std::string& filepath, mate::Arguments* args) {
std::string filename;
if (!args->GetNext(&filename)) {
filename = filepath;
}
window_->PreviewFile(filepath, filename);
}

2
atom/browser/api/atom_api_window.h
View file

@ -170,7 +170,7 @@ class Window : public mate::TrackableObject<Window>,
void SetMenuBarVisibility(bool visible);
bool IsMenuBarVisible();
void SetAspectRatio(double aspect_ratio, mate::Arguments* args);
void PreviewFile(const std::string& filepath, const std::string& filename);
void PreviewFile(const std::string& filepath, mate::Arguments* args);
void SetParentWindow(v8::Local<v8::Value> value, mate::Arguments* args);
v8::Local<v8::Value> GetParentWindow() const;
std::vector<v8::Local<v8::Object>> GetChildWindows() const;