mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

feat: custom toast xml and failure reporting for notifications (#25401)

Browse source 
* allow custom toast xml and report failures

* docs

* tests

* don't use namespaces

* lint doesn't like trailing commas

* addressing feedback
This commit is contained in:
bitdisaster 2020-09-29 12:20:10 -07:00 • committed by GitHub
parent d2282ac51a
commit b43859f098
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 282 additions and 219 deletions
Download patch file Download diff file Expand all files Collapse all files

3
shell/browser/notifications/notification.h
View file

@ -38,6 +38,7 @@ struct NotificationOptions {
base::string16 urgency; // Linux
std::vector<NotificationAction> actions;
base::string16 close_button_text;
base::string16 toast_xml;
NotificationOptions();
~NotificationOptions();
@ -56,7 +57,7 @@ class Notification {
// Should be called by derived classes.
void NotificationClicked();
void NotificationDismissed();
void NotificationFailed();
void NotificationFailed(const std::string& error = "");
// delete this.
void Destroy();