mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

chore: omit superceded Chromium updates from notes (#19400)

Browse source 
* feat: omit superceded Chromium updates from notes

* chore: simplify changed code
This commit is contained in:
Charles Kerr 2019-07-23 15:50:18 -05:00 committed by Shelley Vohr
parent 103b38650f
commit b3fb7497c2
1 changed files with 16 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
script/release/notes/notes.js
View file

@ -591,6 +591,8 @@ const getNotes = async (fromRef, toRef, newVersion) => {
})
}
pool.commits = removeSupercededChromiumUpdates(pool.commits)
const notes = {
breaking: [],
docs: [],
@ -623,6 +625,20 @@ const getNotes = async (fromRef, toRef, newVersion) => {
return notes
}
const removeSupercededChromiumUpdates = (commits) => {
const chromiumRegex = /^Updated Chromium to \d+\.\d+\.\d+\.\d+/
const updates = commits.filter(commit => (commit.note || commit.subject).match(chromiumRegex))
const keepers = commits.filter(commit => !updates.includes(commit))
// keep the newest update.
if (updates.length) {
updates.sort((a, b) => a.originalPr.number - b.originalPr.number)
keepers.push(updates.pop())
}
return keepers
}
/***
**** Render
***/