mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: potential "Object has been destroyed" error in BrowserWindow.getFocusedWindow (#35520)

Browse source
This commit is contained in:
Milan Burda 2022-09-12 23:46:05 +02:00 • committed by GitHub
parent c14f52aeb7
commit b3a744db8a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
lib/browser/api/browser-window.ts
View file

@ -72,9 +72,8 @@ BrowserWindow.getAllWindows = () => {
BrowserWindow.getFocusedWindow = () => { BrowserWindow.getFocusedWindow = () => {
for (const window of BrowserWindow.getAllWindows()) { for (const window of BrowserWindow.getAllWindows()) {
const hasWC = window.webContents && !window.webContents.isDestroyed(); if (!window.isDestroyed() && window.webContents && !window.webContents.isDestroyed()) {
if (!window.isDestroyed() && hasWC) { if (window.isFocused() || window.webContents.isDevToolsFocused()) return window;
if (window.isFocused() || window.isDevToolsFocused()) return window;
} }
} }
return null; return null;