mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Disable deprecation warning of crashReported.setExtraParameter()

Browse source 
It caused a couple of Crash Reported tests to timeout on Mac.
Task to enable it back:
https://github.com/electron/electron/issues/11012
This commit is contained in:
Aleksei Kuzmin 2017-11-04 07:45:22 +03:00
parent 8736a41cfb
commit b3a1fc65e5
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
lib/common/api/crash-reporter.js
View file

@ -106,10 +106,14 @@ class CrashReporter {
// TODO(2.0) Remove // TODO(2.0) Remove
setExtraParameter (key, value) { setExtraParameter (key, value) {
if (!process.noDeprecations) { // TODO(alexeykuzmin): Warning disabled since it caused
deprecate.warn('crashReporter.setExtraParameter', // a couple of Crash Reported tests to time out on Mac. Add it back.
'crashReporter.addExtraParameter or crashReporter.removeExtraParameter') // https://github.com/electron/electron/issues/11012
}
// if (!process.noDeprecations) {
// deprecate.warn('crashReporter.setExtraParameter',
// 'crashReporter.addExtraParameter or crashReporter.removeExtraParameter')
// }
binding.setExtraParameter(key, value) binding.setExtraParameter(key, value)
} }