mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

build: fix release notes script bug that omitted edited release-clerk comments (#40634)

Browse source 
* build: fix release notes script bug that omitted edited release-clerk comments

add a warning when neither notes nor no-notes are found

* fixup! build: fix release notes script bug that omitted edited release-clerk comments

use console.warn() instead of console.log()
This commit is contained in:
Charles Kerr 2023-11-30 05:41:48 -06:00 committed by GitHub
parent 763bc62c7f
commit b2fcc15ec7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
script/release/notes/notes.js
View file

@ -99,7 +99,7 @@ const getNoteFromClerk = async (ghKey) => {
const CLERK_LOGIN = 'release-clerk[bot]'; const CLERK_LOGIN = 'release-clerk[bot]';
const CLERK_NO_NOTES = '**No Release Notes**'; const CLERK_NO_NOTES = '**No Release Notes**';
const PERSIST_LEAD = '**Release Notes Persisted**\n\n'; const PERSIST_LEAD = '**Release Notes Persisted**';
const QUOTE_LEAD = '> '; const QUOTE_LEAD = '> ';
for (const comment of comments.data.reverse()) { for (const comment of comments.data.reverse()) {
@ -130,6 +130,8 @@ const getNoteFromClerk = async (ghKey) => {
.trim(); .trim();
} }
} }
console.warn(`WARN: no notes found in ${buildPullURL(ghKey)}`);
}; };
/** /**