diff --git a/atom/browser/web_contents_permission_helper.cc b/atom/browser/web_contents_permission_helper.cc index f363e2eb406..2d85009c79a 100644 --- a/atom/browser/web_contents_permission_helper.cc +++ b/atom/browser/web_contents_permission_helper.cc @@ -53,13 +53,6 @@ WebContentsPermissionHelper::~WebContentsPermissionHelper() { } void WebContentsPermissionHelper::RequestPermission( - content::PermissionType permission, - const base::Callback& callback, - bool user_gesture) { - RequestPermissionWithDetails(permission, callback, user_gesture, nullptr); -} - -void WebContentsPermissionHelper::RequestPermissionWithDetails( content::PermissionType permission, const base::Callback& callback, bool user_gesture, @@ -107,7 +100,7 @@ void WebContentsPermissionHelper::RequestOpenExternalPermission( const GURL& url) { base::DictionaryValue details; details.SetString("externalURL", url.spec()); - RequestPermissionWithDetails( + RequestPermission( static_cast(PermissionType::OPEN_EXTERNAL), callback, user_gesture, &details); } diff --git a/atom/browser/web_contents_permission_helper.h b/atom/browser/web_contents_permission_helper.h index 49fa39e3866..02879c68e36 100644 --- a/atom/browser/web_contents_permission_helper.h +++ b/atom/browser/web_contents_permission_helper.h @@ -43,12 +43,8 @@ class WebContentsPermissionHelper void RequestPermission( content::PermissionType permission, const base::Callback& callback, - bool user_gesture = false); - void RequestPermissionWithDetails( - content::PermissionType permission, - const base::Callback& callback, - bool user_gesture, - const base::DictionaryValue* details); + bool user_gesture = false, + const base::DictionaryValue* details = nullptr); content::WebContents* web_contents_;