From 1b2b7fc4ce717ebe1c6482de328eec69d76eb924 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Wed, 11 May 2016 12:48:46 +0200 Subject: [PATCH 1/2] Listen for devtools-opened on webContents --- lib/browser/chrome-extension.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/browser/chrome-extension.js b/lib/browser/chrome-extension.js index 562e77a11509..d9e973de6bec 100644 --- a/lib/browser/chrome-extension.js +++ b/lib/browser/chrome-extension.js @@ -136,7 +136,7 @@ app.once('ready', function () { init = BrowserWindow.prototype._init BrowserWindow.prototype._init = function () { init.call(this) - return this.on('devtools-opened', function () { + return this.webContents.on('devtools-opened', function () { return this._loadDevToolsExtensions(Object.keys(extensionInfoMap).map(function (key) { return extensionInfoMap[key] })) From a32f50ef6465333fb6de55ccca4a19718c4e6d79 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Wed, 11 May 2016 12:54:52 +0200 Subject: [PATCH 2/2] Use arrow function for this binding --- lib/browser/chrome-extension.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/browser/chrome-extension.js b/lib/browser/chrome-extension.js index d9e973de6bec..2056a9b89973 100644 --- a/lib/browser/chrome-extension.js +++ b/lib/browser/chrome-extension.js @@ -136,7 +136,7 @@ app.once('ready', function () { init = BrowserWindow.prototype._init BrowserWindow.prototype._init = function () { init.call(this) - return this.webContents.on('devtools-opened', function () { + return this.webContents.on('devtools-opened', () => { return this._loadDevToolsExtensions(Object.keys(extensionInfoMap).map(function (key) { return extensionInfoMap[key] }))