From b288f3ee592e15cd1ca012bc6ac36530f89a5e9c Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Mon, 22 Jul 2024 19:12:59 +0200 Subject: [PATCH] refactor: remove WindowListObserver::OnWindowAdded() (#42984) refactor: remove WindowListObserver::OnWindowRemove() these have never been used Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr --- shell/browser/window_list.cc | 6 ------ shell/browser/window_list_observer.h | 6 ------ 2 files changed, 12 deletions(-) diff --git a/shell/browser/window_list.cc b/shell/browser/window_list.cc index 78378f3aa9ad..da02b5e17e50 100644 --- a/shell/browser/window_list.cc +++ b/shell/browser/window_list.cc @@ -51,9 +51,6 @@ void WindowList::AddWindow(NativeWindow* window) { // Push |window| on the appropriate list instance. WindowVector& windows = GetInstance()->windows_; windows.push_back(window); - - for (WindowListObserver& observer : GetObservers()) - observer.OnWindowAdded(window); } // static @@ -62,9 +59,6 @@ void WindowList::RemoveWindow(NativeWindow* window) { windows.erase(std::remove(windows.begin(), windows.end(), window), windows.end()); - for (WindowListObserver& observer : GetObservers()) - observer.OnWindowRemoved(window); - if (windows.empty()) { for (WindowListObserver& observer : GetObservers()) observer.OnWindowAllClosed(); diff --git a/shell/browser/window_list_observer.h b/shell/browser/window_list_observer.h index 3719b165a4bd..5b7fc8d805f7 100644 --- a/shell/browser/window_list_observer.h +++ b/shell/browser/window_list_observer.h @@ -13,12 +13,6 @@ class NativeWindow; class WindowListObserver : public base::CheckedObserver { public: - // Called immediately after a window is added to the list. - virtual void OnWindowAdded(NativeWindow* window) {} - - // Called immediately after a window is removed from the list. - virtual void OnWindowRemoved(NativeWindow* window) {} - // Called when a window close is cancelled by beforeunload handler. virtual void OnWindowCloseCancelled(NativeWindow* window) {}