mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Shell openExternal can take optional callback (macOS)

Browse source
This commit is contained in:
Gabriel Handford 2016-10-13 13:28:11 -07:00 • committed by Cheng Zhao
parent 1b5b29901c
commit b266533dfc
6 changed files with 85 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

13
atom/common/platform_util_win.cc
View file

@ -299,7 +299,7 @@ bool OpenItem(const base::FilePath& full_path) {
return ui::win::OpenFileViaShell(full_path);
}
bool OpenExternal(const base::string16& url, bool activate) {
bool openExternal(const base::string16& url, bool activate) {
// Quote the input scheme to be sure that the command does not have
// parameters unexpected by the external program. This url should already
// have been escaped.
@ -316,6 +316,17 @@ bool OpenExternal(const base::string16& url, bool activate) {
return true;
}
bool OpenExternal(const base::string16& url, bool activate) {
return openExternal(url, activate);
}
bool OpenExternal(const base::string16& url, bool activate, const OpenExternalCallback& callback) {
// TODO: Implement async open if callback is specified
bool opened = openExternal(url, activate)
callback(opened);
return opened;
}
bool MoveItemToTrash(const base::FilePath& path) {
base::win::ScopedCOMInitializer com_initializer;
if (!com_initializer.succeeded())