Merge pull request #4616 from deepak1556/media_device_enumeration_patch

browser: allow enumeration of media device labels

atom/browser/api/atom_api_web_contents.cc

@@ -463,6 +463,13 @@ void WebContents::FindReply(content::WebContents* web_contents,
   }
 }
 
+bool WebContents::CheckMediaAccessPermission(
+    content::WebContents* web_contents,
+    const GURL& security_origin,
+    content::MediaStreamType type) {
+  return true;
+}
+
 void WebContents::RequestMediaAccessPermission(
     content::WebContents* web_contents,
     const content::MediaStreamRequest& request,

atom/browser/api/atom_api_web_contents.h

@@ -202,6 +202,10 @@ class WebContents : public mate::TrackableObject<WebContents>,
                  const gfx::Rect& selection_rect,
                  int active_match_ordinal,
                  bool final_update) override;
+  bool CheckMediaAccessPermission(
+      content::WebContents* web_contents,
+      const GURL& security_origin,
+      content::MediaStreamType type) override;
   void RequestMediaAccessPermission(
       content::WebContents* web_contents,
       const content::MediaStreamRequest& request,

spec/chromium-spec.js

@@ -87,6 +87,20 @@ describe('chromium feature', function() {
     });
   });
 
+  describe('navigator.mediaDevices', function() {
+    if (process.env.TRAVIS === 'true') {
+      return;
+    }
+
+    it('can return labels of enumerated devices', function(done) {
+      navigator.mediaDevices.enumerateDevices().then((devices) => {
+        const result = devices.some((device) => !!device.label);
+        if (result)
+          done();
+      });
+    });
+  });
+
   describe('navigator.language', function() {
     it('should not be empty', function() {
       assert.notEqual(navigator.language, '');