mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: cleanup some typos in comments (#25770)

Browse source
This commit is contained in:
David Sanders 2020-10-13 10:25:21 -07:00 • committed by GitHub
parent 183e92a5ae
commit b194030a34
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
31 changed files with 38 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

2
shell/common/gin_converters/native_window_converter.h
View file

@ -15,7 +15,7 @@ struct Converter<electron::NativeWindow*> {
static bool FromV8(v8::Isolate* isolate,
v8::Local<v8::Value> val,
electron::NativeWindow** out) {
// null would be tranfered to NULL.
// null would be transferred to NULL.
if (val->IsNull()) {
*out = NULL;
return true;

4
shell/common/gin_converters/net_converter.cc
View file

@ -273,8 +273,8 @@ v8::Local<v8::Value> Converter<network::ResourceRequestBody>::ToV8(
case network::mojom::DataElementType::kDataPipe: {
upload_data.Set("type", "blob");
// TODO(zcbenz): After the NetworkService refactor, the old blobUUID API
// becomes unecessarily complex, we should deprecate the getBlobData API
// and return the DataPipeHolder wrapper directly.
// becomes unnecessarily complex, we should deprecate the getBlobData
// API and return the DataPipeHolder wrapper directly.
auto holder = electron::api::DataPipeHolder::Create(isolate, element);
upload_data.Set("blobUUID", holder->id());
// The lifetime of data pipe is bound to the uploadData object.