docs: fix fiddles (#39060)

* refactor: replace Array.prototype.forEach.call with plain for-of

* fix: add missing contextIsolation: false

* fix: open links in default browser
This commit is contained in:
Milan Burda 2023-07-13 10:10:37 +02:00 committed by GitHub
parent a8622aed7b
commit b14b876d50
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
36 changed files with 126 additions and 24 deletions

View file

@ -11,6 +11,7 @@ function createWindow () {
height: 400,
title: 'Create a frameless window',
webPreferences: {
contextIsolation: false,
nodeIntegration: true
}
})

View file

@ -12,6 +12,7 @@ function createWindow () {
width: 800,
height: 600,
webPreferences: {
contextIsolation: false,
nodeIntegration: true
}
})

View file

@ -1,4 +1,4 @@
const { ipcRenderer } = require('electron')
const { ipcRenderer, shell } = require('electron')
const newWindowBtn = document.getElementById('frameless-window')
@ -6,3 +6,15 @@ newWindowBtn.addEventListener('click', () => {
const url = 'data:text/html,<h2>Hello World!</h2><a id="close" href="javascript:window.close()">Close this Window</a>'
ipcRenderer.send('create-frameless-window', { url })
})
const links = document.querySelectorAll('a[href]')
for (const link of links) {
const url = link.getAttribute('href')
if (url.indexOf('http') === 0) {
link.addEventListener('click', (e) => {
e.preventDefault()
shell.openExternal(url)
})
}
}

View file

@ -22,6 +22,7 @@ function createWindow () {
width: 800,
height: 600,
webPreferences: {
contextIsolation: false,
nodeIntegration: true
}
})

View file

@ -14,7 +14,7 @@ manageWindowBtn.addEventListener('click', (event) => {
ipcRenderer.send('create-demo-window')
})
Array.prototype.forEach.call(links, (link) => {
for (const link of links) {
const url = link.getAttribute('href')
if (url.indexOf('http') === 0) {
link.addEventListener('click', (e) => {
@ -22,4 +22,4 @@ Array.prototype.forEach.call(links, (link) => {
shell.openExternal(url)
})
}
})
}

View file

@ -12,6 +12,7 @@ function createWindow () {
width: 800,
height: 600,
webPreferences: {
contextIsolation: false,
nodeIntegration: true
}
})

View file

@ -7,6 +7,7 @@ function createWindow () {
width: 800,
height: 600,
webPreferences: {
contextIsolation: false,
nodeIntegration: true
}
})

View file

@ -28,7 +28,7 @@ listenToWindowBtn.addEventListener('click', () => {
const links = document.querySelectorAll('a[href]')
Array.prototype.forEach.call(links, (link) => {
for (const link of links) {
const url = link.getAttribute('href')
if (url.indexOf('http') === 0) {
link.addEventListener('click', (e) => {
@ -36,4 +36,4 @@ Array.prototype.forEach.call(links, (link) => {
shell.openExternal(url)
})
}
})
}