mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix: take foreground visibility into account for isVisible on macOS (#17463)

Browse source
This commit is contained in:
Shelley Vohr 2019-03-20 15:33:59 -07:00 committed by GitHub
parent a82bbd010e
commit b140a82fe8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
atom/browser/native_window_mac.mm
View file

@ -576,7 +576,12 @@ void NativeWindowMac::Hide() {
} }
bool NativeWindowMac::IsVisible() { bool NativeWindowMac::IsVisible() {
return [window_ isVisible]; bool occluded = [window_ occlusionState] == NSWindowOcclusionStateVisible;
// For a window to be visible, it must be visible to the user in the
// foreground of the app, which means that it should not be minimized or
// occluded
return [window_ isVisible] && !occluded && !IsMinimized();
} }
bool NativeWindowMac::IsEnabled() { bool NativeWindowMac::IsEnabled() {