From b11836e1959175430e0c851e0bc461f385ffbe3d Mon Sep 17 00:00:00 2001 From: John Kleinschmidt Date: Tue, 12 May 2020 14:52:56 -0400 Subject: [PATCH] build: use correct v8_context_snapshot_generator in mksnapshot zip (#23536) --- .circleci/config.yml | 2 ++ BUILD.gn | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 73a112e1fa2a..237ac85068c1 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -670,8 +670,10 @@ step-mksnapshot-build: &step-mksnapshot-build if [ "`uname`" != "Darwin" ]; then if [ "$TARGET_ARCH" == "arm" ]; then electron/script/strip-binaries.py --file $PWD/out/Default/clang_x86_v8_arm/mksnapshot + electron/script/strip-binaries.py --file $PWD/out/Default/clang_x86_v8_arm/v8_context_snapshot_generator elif [ "$TARGET_ARCH" == "arm64" ]; then electron/script/strip-binaries.py --file $PWD/out/Default/clang_x64_v8_arm64/mksnapshot + electron/script/strip-binaries.py --file $PWD/out/Default/clang_x64_v8_arm64/v8_context_snapshot_generator else electron/script/strip-binaries.py --file $PWD/out/Default/mksnapshot electron/script/strip-binaries.py --file $PWD/out/Default/v8_context_snapshot_generator diff --git a/BUILD.gn b/BUILD.gn index 65d9dd2b751b..4fd86f9afd80 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -1269,7 +1269,7 @@ dist_zip("electron_chromedriver_zip") { mksnapshot_deps = [ ":licenses", - "//tools/v8_context_snapshot:v8_context_snapshot_generator", + "//tools/v8_context_snapshot:v8_context_snapshot_generator($v8_snapshot_toolchain)", "//v8:mksnapshot($v8_snapshot_toolchain)", ]