mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Rename IsDevToolsOpened to IsDevToolsViewShowing.

Browse source
This commit is contained in:
Cheng Zhao 2013-12-09 04:34:44 -08:00
commit b080e5c52d
10 changed files with 11 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
brightray/browser/inspectable_web_contents.h
View file

@ -22,7 +22,7 @@ class InspectableWebContents {
virtual content::WebContents* GetWebContents() const = 0; virtual content::WebContents* GetWebContents() const = 0;
virtual void ShowDevTools() = 0; virtual void ShowDevTools() = 0;
virtual bool IsDevToolsOpened() = 0; virtual bool IsDevToolsViewShowing() = 0;
}; };
} // namespace brightray } // namespace brightray

4
brightray/browser/inspectable_web_contents_impl.cc
View file

@ -96,8 +96,8 @@ void InspectableWebContentsImpl::ShowDevTools() {
view_->ShowDevTools(); view_->ShowDevTools();
} }
bool InspectableWebContentsImpl::IsDevToolsOpened() { bool InspectableWebContentsImpl::IsDevToolsViewShowing() {
return devtools_web_contents_ && view_->IsDevToolsOpened(); return devtools_web_contents_ && view_->IsDevToolsViewShowing();
} }
void InspectableWebContentsImpl::UpdateFrontendDockSide() { void InspectableWebContentsImpl::UpdateFrontendDockSide() {

2
brightray/browser/inspectable_web_contents_impl.h
View file

@ -41,7 +41,7 @@ class InspectableWebContentsImpl :
virtual content::WebContents* GetWebContents() const OVERRIDE; virtual content::WebContents* GetWebContents() const OVERRIDE;
virtual void ShowDevTools() OVERRIDE; virtual void ShowDevTools() OVERRIDE;
virtual bool IsDevToolsOpened() OVERRIDE; virtual bool IsDevToolsViewShowing() OVERRIDE;
content::WebContents* devtools_web_contents() { content::WebContents* devtools_web_contents() {
return devtools_web_contents_.get(); return devtools_web_contents_.get();

2
brightray/browser/inspectable_web_contents_view.h
View file

@ -13,7 +13,7 @@ class InspectableWebContentsView {
virtual void ShowDevTools() = 0; virtual void ShowDevTools() = 0;
virtual void CloseDevTools() = 0; virtual void CloseDevTools() = 0;
virtual bool IsDevToolsOpened() = 0; virtual bool IsDevToolsViewShowing() = 0;
virtual bool SetDockSide(const std::string& side) = 0; virtual bool SetDockSide(const std::string& side) = 0;
}; };

2
brightray/browser/inspectable_web_contents_view_mac.h
View file

@ -19,7 +19,7 @@ class InspectableWebContentsViewMac : public InspectableWebContentsView {
virtual gfx::NativeView GetNativeView() const OVERRIDE; virtual gfx::NativeView GetNativeView() const OVERRIDE;
virtual void ShowDevTools() OVERRIDE; virtual void ShowDevTools() OVERRIDE;
virtual void CloseDevTools() OVERRIDE; virtual void CloseDevTools() OVERRIDE;
virtual bool IsDevToolsOpened() OVERRIDE; virtual bool IsDevToolsViewShowing() OVERRIDE;
virtual bool SetDockSide(const std::string& side) OVERRIDE; virtual bool SetDockSide(const std::string& side) OVERRIDE;
InspectableWebContentsImpl* inspectable_web_contents() { InspectableWebContentsImpl* inspectable_web_contents() {

2
brightray/browser/inspectable_web_contents_view_mac.mm
View file

@ -29,7 +29,7 @@ void InspectableWebContentsViewMac::CloseDevTools() {
[view_ setDevToolsVisible:NO]; [view_ setDevToolsVisible:NO];
} }
bool InspectableWebContentsViewMac::IsDevToolsOpened() { bool InspectableWebContentsViewMac::IsDevToolsViewShowing() {
return [view_ isDevToolsVisible]; return [view_ isDevToolsVisible];
} }

2
brightray/browser/linux/inspectable_web_contents_view_linux.cc
View file

@ -166,7 +166,7 @@ void InspectableWebContentsViewLinux::CloseDevTools() {
} }
} }
bool InspectableWebContentsViewLinux::IsDevToolsOpened() { bool InspectableWebContentsViewLinux::IsDevToolsViewShowing() {
auto devtools_web_contents = auto devtools_web_contents =
inspectable_web_contents()->devtools_web_contents(); inspectable_web_contents()->devtools_web_contents();
GtkWidget* devtools = devtools_web_contents->GetView()->GetNativeView(); GtkWidget* devtools = devtools_web_contents->GetView()->GetNativeView();

2
brightray/browser/linux/inspectable_web_contents_view_linux.h
View file

@ -18,7 +18,7 @@ class InspectableWebContentsViewLinux : public InspectableWebContentsView {
virtual gfx::NativeView GetNativeView() const OVERRIDE; virtual gfx::NativeView GetNativeView() const OVERRIDE;
virtual void ShowDevTools() OVERRIDE; virtual void ShowDevTools() OVERRIDE;
virtual void CloseDevTools() OVERRIDE; virtual void CloseDevTools() OVERRIDE;
virtual bool IsDevToolsOpened() OVERRIDE; virtual bool IsDevToolsViewShowing() OVERRIDE;
virtual bool SetDockSide(const std::string& side) OVERRIDE; virtual bool SetDockSide(const std::string& side) OVERRIDE;
InspectableWebContentsImpl* inspectable_web_contents() { InspectableWebContentsImpl* inspectable_web_contents() {

2
brightray/browser/win/inspectable_web_contents_view_win.cc
View file

@ -57,7 +57,7 @@ void InspectableWebContentsViewWin::CloseDevTools() {
SendMessage(devtools_window_->hwnd(), WM_CLOSE, 0, 0); SendMessage(devtools_window_->hwnd(), WM_CLOSE, 0, 0);
} }
bool InspectableWebContentsViewWin::IsDevToolsOpened() { bool InspectableWebContentsViewWin::IsDevToolsViewShowing() {
return devtools_window_; return devtools_window_;
} }

2
brightray/browser/win/inspectable_web_contents_view_win.h
View file

@ -20,7 +20,7 @@ class InspectableWebContentsViewWin : public InspectableWebContentsView {
virtual gfx::NativeView GetNativeView() const OVERRIDE; virtual gfx::NativeView GetNativeView() const OVERRIDE;
virtual void ShowDevTools() OVERRIDE; virtual void ShowDevTools() OVERRIDE;
virtual void CloseDevTools() OVERRIDE; virtual void CloseDevTools() OVERRIDE;
virtual bool IsDevToolsOpened() OVERRIDE; virtual bool IsDevToolsViewShowing() OVERRIDE;
virtual bool SetDockSide(const std::string& side) OVERRIDE; virtual bool SetDockSide(const std::string& side) OVERRIDE;
InspectableWebContentsImpl* inspectable_web_contents() { InspectableWebContentsImpl* inspectable_web_contents() {