mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Correctly handle window's lifetime when it's closed.

Browse source
This commit is contained in:
Cheng Zhao 2013-05-01 23:28:01 +08:00
parent 9e489cae0c
commit afe07521c5
7 changed files with 23 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

17
browser/api/atom_api_window.cc
View file

@ -44,13 +44,24 @@ Window::Window(v8::Handle<v8::Object> wrapper, base::DictionaryValue* options)
}
Window::~Window() {
window_->RemoveObserver(this);
}
void Window::OnPageTitleUpdated(bool* prevent_default,
const std::string& title) {
scoped_ptr<base::ListValue> args(new base::ListValue);
args->AppendString(title);
*prevent_default = Emit("page-title-updated", args.get());
base::ListValue args;
args.AppendString(title);
*prevent_default = Emit("page-title-updated", &args);
}
void Window::WillCloseWindow(bool* prevent_default) {
base::ListValue args;
*prevent_default = Emit("close", &args);
}
void Window::OnWindowClosed() {
// Free memory immediately when window is closed.
delete this;
}
// static