mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

destruct objects in stack order

Browse source
This commit is contained in:
Cheng Zhao 2018-05-17 09:09:45 +09:00
parent fd4a0626c5
commit aeeb2a259f
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
atom/browser/atom_browser_main_parts.cc
View file

@ -121,7 +121,10 @@ int AtomBrowserMainParts::GetExitCode() {
void AtomBrowserMainParts::RegisterDestructionCallback( void AtomBrowserMainParts::RegisterDestructionCallback(
base::OnceClosure callback) { base::OnceClosure callback) {
destructors_.insert(destructors_.end(), std::move(callback)); // The destructors should be called in reversed order, so dependencies between
// JavaScript objects can be correctly resolved.
// For example WebContentsView => WebContents => Session.
destructors_.insert(destructors_.begin(), std::move(callback));
} }
void AtomBrowserMainParts::PreEarlyInitialization() { void AtomBrowserMainParts::PreEarlyInitialization() {