mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Rename 'finish-launching' event to 'ready',

Browse source 
'finish-launching' is more like a OS X message name, and in atom-shell
it means initialization has done, so 'ready' seems to be a better name
and more easy to remember.

The 'will-finish-launching' event just represents the corresponding
message on OS X and is the same with 'ready' on other platforms, so we
keep its name to indicate that it's only useful for OS X specified
code.
This commit is contained in:
Cheng Zhao 2013-12-27 11:08:26 +08:00
parent d3f33152d0
commit aedacd39d2
6 changed files with 16 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
browser/api/atom_api_app.cc
View file

@ -49,7 +49,7 @@ void App::OnWillFinishLaunching() {
}
void App::OnFinishLaunching() {
Emit("finish-launching");
Emit("ready");
}
// static