From aebcd3a8c43234b4a17816dfffeee2de07fe29c4 Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Mon, 22 May 2023 15:10:29 +0200 Subject: [PATCH] build: try removing V8 symbol export patch for Windows (#38391) --- patches/v8/.patches | 1 - ...ort_symbols_needed_for_windows_build.patch | 33 ------------------- 2 files changed, 34 deletions(-) delete mode 100644 patches/v8/export_symbols_needed_for_windows_build.patch diff --git a/patches/v8/.patches b/patches/v8/.patches index 8ffd5dd430f1..80aaafd7cf46 100644 --- a/patches/v8/.patches +++ b/patches/v8/.patches @@ -1,5 +1,4 @@ build_gn.patch -export_symbols_needed_for_windows_build.patch do_not_export_private_v8_symbols_on_windows.patch fix_build_deprecated_attribute_for_older_msvc_versions.patch fix_disable_implies_dcheck_for_node_stream_array_buffers.patch diff --git a/patches/v8/export_symbols_needed_for_windows_build.patch b/patches/v8/export_symbols_needed_for_windows_build.patch deleted file mode 100644 index 297e336c8aa1..000000000000 --- a/patches/v8/export_symbols_needed_for_windows_build.patch +++ /dev/null @@ -1,33 +0,0 @@ -From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 -From: Jeremy Apthorp -Date: Mon, 15 Apr 2019 18:12:08 -0700 -Subject: Export symbols needed for Windows build - -These symbols are required to build v8 with BUILD_V8_SHARED on Windows. - -diff --git a/src/objects/objects.h b/src/objects/objects.h -index 7c08126e79d07c9135964043232548e8de08ac5a..e9eb8179fb7388ab2a0d645108141c4797a9dc2f 100644 ---- a/src/objects/objects.h -+++ b/src/objects/objects.h -@@ -976,7 +976,7 @@ enum AccessorComponent { ACCESSOR_GETTER, ACCESSOR_SETTER }; - // Utility superclass for stack-allocated objects that must be updated - // on gc. It provides two ways for the gc to update instances, either - // iterating or updating after gc. --class Relocatable { -+class V8_EXPORT_PRIVATE Relocatable { - public: - explicit inline Relocatable(Isolate* isolate); - inline virtual ~Relocatable(); -diff --git a/src/objects/ordered-hash-table.h b/src/objects/ordered-hash-table.h -index 35523831c3ec19d1b286316550d1731b4ed73ccb..91a94826b1e2e8e8f3200e0af62cfd1230844b39 100644 ---- a/src/objects/ordered-hash-table.h -+++ b/src/objects/ordered-hash-table.h -@@ -64,7 +64,7 @@ namespace internal { - // deleted elements count. - // [kPrefixSize + 3 + NumberOfDeletedElements()..length]: Not used - template --class OrderedHashTable : public FixedArray { -+class V8_EXPORT_PRIVATE OrderedHashTable : public FixedArray { - public: - // Returns an OrderedHashTable (possibly |table|) with enough space - // to add at least one new element.