mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Keep compatibility with old API style

Browse source
This commit is contained in:
Cheng Zhao 2015-10-23 15:50:55 +08:00
parent f89d28a63e
commit aeafc46ded
2 changed files with 12 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
atom/browser/api/atom_api_auto_updater.cc
View file

@ -8,6 +8,7 @@
#include "atom/browser/browser.h" #include "atom/browser/browser.h"
#include "atom/browser/native_window.h" #include "atom/browser/native_window.h"
#include "atom/browser/window_list.h" #include "atom/browser/window_list.h"
#include "atom/common/native_mate_converters/callback.h"
#include "atom/common/node_includes.h" #include "atom/common/node_includes.h"
#include "native_mate/dictionary.h" #include "native_mate/dictionary.h"
#include "native_mate/object_template_builder.h" #include "native_mate/object_template_builder.h"
@ -68,7 +69,9 @@ void AutoUpdater::OnUpdateDownloaded(const std::string& release_notes,
const std::string& release_name, const std::string& release_name,
const base::Time& release_date, const base::Time& release_date,
const std::string& url) { const std::string& url) {
Emit("update-downloaded", release_notes, release_name, release_date, url); Emit("update-downloaded", release_notes, release_name, release_date, url,
// Keep compatibility with old APIs.
base::Bind(&AutoUpdater::QuitAndInstall, base::Unretained(this)));
} }
void AutoUpdater::OnWindowAllClosed() { void AutoUpdater::OnWindowAllClosed() {

13
docs/api/auto-updater.md
View file

@ -136,10 +136,8 @@ Returns:
* `releaseName` String * `releaseName` String
* `releaseDate` Date * `releaseDate` Date
* `updateUrl` String * `updateUrl` String
* `quitAndUpdate` Function
Emitted when an update has been downloaded. Calling `quitAndUpdate()` will Emitted when an update has been downloaded.
restart the application and install the update.
## Methods ## Methods
@ -149,10 +147,15 @@ The `autoUpdater` object has the following methods:
* `url` String * `url` String
Set the `url` and initialize the auto updater. The `url` cannot be changed Sets the `url` and initialize the auto updater. The `url` cannot be changed
once it is set. once it is set.
### `autoUpdater.checkForUpdates()` ### `autoUpdater.checkForUpdates()`
Ask the server whether there is an update. You must call `setFeedUrl` before Asks the server whether there is an update. You must call `setFeedUrl` before
using this API. using this API.
### `autoUpdater.quitAndUpdate()`
Restarts the app and install the update after it has been downloaded. It should
only be called after `update-downloaded` has been emitted.