mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

rename all references to default_button_index -> default_id to keep consistent with cancel_id

Browse source
This commit is contained in:
leethomas 2016-01-10 15:33:27 -08:00
parent dfce803045
commit ae5c6add11
7 changed files with 28 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

6
atom/browser/api/atom_api_dialog.cc
View file

@ -41,7 +41,7 @@ namespace {
void ShowMessageBox(int type,
const std::vector<std::string>& buttons,
int default_button_index,
int default_id,
int cancel_id,
int options,
const std::string& title,
@ -56,11 +56,11 @@ void ShowMessageBox(int type,
peek,
&callback)) {
atom::ShowMessageBox(window, (atom::MessageBoxType)type, buttons,
default_button_index, cancel_id, options, title,
default_id, cancel_id, options, title,
message, detail, icon, callback);
} else {
int chosen = atom::ShowMessageBox(window, (atom::MessageBoxType)type,
buttons, default_button_index, cancel_id,
buttons, default_id, cancel_id,
options, title, message, detail, icon);
args->Return(chosen);
}

4
atom/browser/api/lib/dialog.coffee
View file

@ -95,7 +95,7 @@ module.exports =
options.message ?= ''
options.detail ?= ''
options.icon ?= null
options.defaultButtonIndex ?= -1
options.defaultId ?= -1
# Choose a default button to get selected when dialog is cancelled.
unless options.cancelId?
@ -109,7 +109,7 @@ module.exports =
binding.showMessageBox messageBoxType,
options.buttons,
options.defaultButtonIndex,
options.defaultId,
options.cancelId,
flags,
options.title,