mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: remove more uses of v8::Isolate::GetCurrent() (#28369)

Browse source
This commit is contained in:
Shelley Vohr 2021-03-29 10:45:08 +00:00 • committed by GitHub
parent ff96fabe5e
commit ae2059eaa1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 43 additions and 44 deletions
Download patch file Download diff file Expand all files Collapse all files

4
shell/browser/api/electron_api_download_item.h
View file

@ -66,7 +66,7 @@ class DownloadItem : public gin::Wrappable<DownloadItem>,
std::string GetFilename() const;
std::string GetContentDisposition() const;
const GURL& GetURL() const;
v8::Local<v8::Value> GetURLChain(v8::Isolate*) const;
v8::Local<v8::Value> GetURLChain() const;
download::DownloadItem::DownloadState GetState() const;
bool IsDone() const;
void SetSaveDialogOptions(const file_dialog::DialogSettings& options);
@ -78,6 +78,8 @@ class DownloadItem : public gin::Wrappable<DownloadItem>,
file_dialog::DialogSettings dialog_options_;
download::DownloadItem* download_item_;
v8::Isolate* isolate_;
base::WeakPtrFactory<DownloadItem> weak_factory_{this};
DISALLOW_COPY_AND_ASSIGN(DownloadItem);