From ac8c205fd754f99a44375564b5e84529c562e0a9 Mon Sep 17 00:00:00 2001 From: Aleksei Kuzmin Date: Thu, 24 Aug 2017 02:08:44 +0300 Subject: [PATCH] Replace deprecated base::NonThreadSafe in chrome in favor of SequenceChecker. https://codereview.chromium.org/2911983003 --- chromium_src/chrome/browser/process_singleton.h | 6 ++++-- chromium_src/chrome/browser/process_singleton_posix.cc | 1 + chromium_src/chrome/browser/process_singleton_win.cc | 1 + 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/chromium_src/chrome/browser/process_singleton.h b/chromium_src/chrome/browser/process_singleton.h index d77f5b41df88..3ee6ca8140fc 100644 --- a/chromium_src/chrome/browser/process_singleton.h +++ b/chromium_src/chrome/browser/process_singleton.h @@ -18,7 +18,7 @@ #include "base/logging.h" #include "base/memory/ref_counted.h" #include "base/process/process.h" -#include "base/threading/non_thread_safe.h" +#include "base/sequence_checker.h" #include "ui/gfx/native_widget_types.h" #if defined(OS_POSIX) && !defined(OS_ANDROID) @@ -44,7 +44,7 @@ class CommandLine; // - the Windows implementation uses an invisible global message window; // - the Linux implementation uses a Unix domain socket in the user data dir. -class ProcessSingleton : public base::NonThreadSafe { +class ProcessSingleton { public: enum NotifyResult { PROCESS_NONE, @@ -179,6 +179,8 @@ class ProcessSingleton : public base::NonThreadSafe { bool listen_on_ready_ = false; #endif + SEQUENCE_CHECKER(sequence_checker_); + DISALLOW_COPY_AND_ASSIGN(ProcessSingleton); }; diff --git a/chromium_src/chrome/browser/process_singleton_posix.cc b/chromium_src/chrome/browser/process_singleton_posix.cc index 1943ad51f635..46e0a6a5d143 100644 --- a/chromium_src/chrome/browser/process_singleton_posix.cc +++ b/chromium_src/chrome/browser/process_singleton_posix.cc @@ -733,6 +733,7 @@ ProcessSingleton::ProcessSingleton( } ProcessSingleton::~ProcessSingleton() { + DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_); } ProcessSingleton::NotifyResult ProcessSingleton::NotifyOtherProcess() { diff --git a/chromium_src/chrome/browser/process_singleton_win.cc b/chromium_src/chrome/browser/process_singleton_win.cc index cce6054d1230..121f6375dac9 100644 --- a/chromium_src/chrome/browser/process_singleton_win.cc +++ b/chromium_src/chrome/browser/process_singleton_win.cc @@ -196,6 +196,7 @@ ProcessSingleton::ProcessSingleton( } ProcessSingleton::~ProcessSingleton() { + DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_); if (lock_file_ != INVALID_HANDLE_VALUE) ::CloseHandle(lock_file_); }