mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: set nativeWindowOpen when sandboxed (#18273)

Browse source
This commit is contained in:
Milan Burda 2019-05-27 02:44:54 +02:00 • committed by Alexey Kuzmin
parent 4ed989587b
commit ac002b3c3c
6 changed files with 44 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

34
spec/webview-spec.js
View file

@ -545,20 +545,30 @@ describe('<webview> tag', function () {
})
describe('allowpopups attribute', () => {
it('can not open new window when not set', async () => {
const message = await startLoadingWebViewAndWaitForMessage(webview, {
src: `file://${fixtures}/pages/window-open-hide.html`
})
expect(message).to.equal('null')
})
const generateSpecs = (description, webpreferences = '') => {
describe(description, () => {
it('can not open new window when not set', async () => {
const message = await startLoadingWebViewAndWaitForMessage(webview, {
webpreferences,
src: `file://${fixtures}/pages/window-open-hide.html`
})
expect(message).to.equal('null')
})
it('can open new window when set', async () => {
const message = await startLoadingWebViewAndWaitForMessage(webview, {
allowpopups: 'on',
src: `file://${fixtures}/pages/window-open-hide.html`
it('can open new window when set', async () => {
const message = await startLoadingWebViewAndWaitForMessage(webview, {
webpreferences,
allowpopups: 'on',
src: `file://${fixtures}/pages/window-open-hide.html`
})
expect(message).to.equal('window')
})
})
expect(message).to.equal('window')
})
}
generateSpecs('without sandbox')
generateSpecs('with sandbox', 'sandbox=yes')
generateSpecs('with nativeWindowOpen', 'nativeWindowOpen=yes')
})
describe('webpreferences attribute', () => {