feat: netLog API for dynamic logging control (#13068)

* Introduce `net.{start|stop}Logging()`

- Slight regression right now as Electron won't automatically start logging net-logs at launch, will soon be fixed
- To implement callback for async controls

* Add `net.isLogging` & optional callback param for `net.stopLogging()`

* Fix small regression on --log-net-log

--log-net-log should work again

* Error on empty file path

* Only start with valid file path

* Remove unused var

* Allow setting log file path before URLRequestContextGetter starts logging

* Add net log tests

* Remove redundant checks

* Use brightray::NetLog

* Clean up code

* Should automatically stop listening

* 🎨 Attempt to fix styles

* Only run non-null callback

* Dump file to tmpdir

* Simplify net log spec

Spawned Electron process on Linux CI can fail to launch

* Separate netLog module

* Remove net logging test from net spec

* Add tests for netLog

* Fix header guard

* Clean up code

* Add netLog.currentlyLoggingPath

* Callback with filepath

* Add test for case when only .stopLogging() is called

* Add docs

* Reintroduce error on invalid arg

* Update copyright

* Update error message

* Juggle file path string types

brightray/browser/net_log.h

@@ -5,6 +5,8 @@
 #ifndef BRIGHTRAY_BROWSER_NET_LOG_H_
 #define BRIGHTRAY_BROWSER_NET_LOG_H_
 
+#include "base/callback.h"
+#include "base/files/file_path.h"
 #include "net/log/net_log.h"
 
 namespace net {
@@ -19,10 +21,18 @@ class NetLog : public net::NetLog {
   ~NetLog() override;
 
   void StartLogging();
+  void StopLogging();
+
+  void StartDynamicLogging(const base::FilePath& path);
+  bool IsDynamicLogging();
+  base::FilePath GetDynamicLoggingPath();
+  void StopDynamicLogging(base::OnceClosure callback = base::OnceClosure());
 
  private:
   // This observer handles writing NetLogs.
   std::unique_ptr<net::FileNetLogObserver> file_net_log_observer_;
+  std::unique_ptr<net::FileNetLogObserver> dynamic_file_net_log_observer_;
+  base::FilePath dynamic_file_net_log_path_;
 
   DISALLOW_COPY_AND_ASSIGN(NetLog);
 };