mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: devirtualize NativeWindow methods (#46930)

Browse source 
* refactor: devirtualize NativeWindow::SetSize()

refactor: devirtualize NativeWindow::GetSize()

refactor: devirtualize NativeWindow::SetPosition()

refactor: devirtualize NativeWindow::GetPosition()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: devirtualize NativeWinodw::SetMinimumSize()

refactor: devirtualize NativeWinodw::GetMinimumSize()

refactor: devirtualize NativeWinodw::SetMaximumSize()

refactor: devirtualize NativeWinodw::GetMaximumSize()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: devirtualize NativeWindow::SetSheetOffset()

refactor: devirtualize NativeWindow::GetSheetOffsetX()

refactor: devirtualize NativeWindow::GetSheetOffsetY()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: devirtualize NativeWindow::GetContentMinimumSize()

refactor: devirtualize NativeWindow::GetContentMaximumSize()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot] 2025-05-05 12:59:31 -04:00 • committed by GitHub
commit aada99e53d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 21 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

34
shell/browser/native_window.h
View file

@ -103,10 +103,13 @@ class NativeWindow : public base::SupportsUserData,
virtual bool IsFullscreen() const = 0;
virtual void SetBounds(const gfx::Rect& bounds, bool animate = false) = 0;
virtual gfx::Rect GetBounds() const = 0;
virtual void SetSize(const gfx::Size& size, bool animate = false);
virtual gfx::Size GetSize() const;
virtual void SetPosition(const gfx::Point& position, bool animate = false);
virtual gfx::Point GetPosition() const;
void SetSize(const gfx::Size& size, bool animate = false);
[[nodiscard]] gfx::Size GetSize() const;
void SetPosition(const gfx::Point& position, bool animate = false);
[[nodiscard]] gfx::Point GetPosition() const;
virtual void SetContentSize(const gfx::Size& size, bool animate = false);
virtual gfx::Size GetContentSize() const;
virtual void SetContentBounds(const gfx::Rect& bounds, bool animate = false);
@ -119,15 +122,20 @@ class NativeWindow : public base::SupportsUserData,
virtual void SetContentSizeConstraints(
const extensions::SizeConstraints& size_constraints);
virtual extensions::SizeConstraints GetContentSizeConstraints() const;
virtual void SetMinimumSize(const gfx::Size& size);
virtual gfx::Size GetMinimumSize() const;
virtual void SetMaximumSize(const gfx::Size& size);
virtual gfx::Size GetMaximumSize() const;
virtual gfx::Size GetContentMinimumSize() const;
virtual gfx::Size GetContentMaximumSize() const;
virtual void SetSheetOffset(const double offsetX, const double offsetY);
virtual double GetSheetOffsetX() const;
virtual double GetSheetOffsetY() const;
void SetMinimumSize(const gfx::Size& size);
[[nodiscard]] gfx::Size GetMinimumSize() const;
void SetMaximumSize(const gfx::Size& size);
[[nodiscard]] gfx::Size GetMaximumSize() const;
[[nodiscard]] gfx::Size GetContentMinimumSize() const;
[[nodiscard]] gfx::Size GetContentMaximumSize() const;
void SetSheetOffset(const double offsetX, const double offsetY);
[[nodiscard]] double GetSheetOffsetX() const;
[[nodiscard]] double GetSheetOffsetY() const;
virtual void SetResizable(bool resizable) = 0;
virtual bool MoveAbove(const std::string& sourceId) = 0;
virtual void MoveTop() = 0;