mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: [wc|bw]-created events do not emit an event object (#19465)

Browse source 
* fix: emit real Event instead of empty object in [wc|bw]

* chore: add ability to emit empty events
This commit is contained in:
Shelley Vohr 2019-07-29 13:54:37 -07:00 • committed by GitHub
parent 33d1e87163
commit aaca9011ae
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 17 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
shell/browser/api/atom_api_event.cc
View file

@ -13,12 +13,17 @@ v8::Local<v8::Object> CreateWithSender(v8::Isolate* isolate,
return mate::internal::CreateJSEvent(isolate, sender, nullptr, base::nullopt);
}
v8::Local<v8::Object> CreateEmpty(v8::Isolate* isolate) {
return mate::internal::CreateEmptyJSEvent(isolate);
}
void Initialize(v8::Local<v8::Object> exports,
v8::Local<v8::Value> unused,
v8::Local<v8::Context> context,
void* priv) {
mate::Dictionary dict(context->GetIsolate(), exports);
dict.SetMethod("createWithSender", &CreateWithSender);
dict.SetMethod("createEmpty", &CreateEmpty);
}
} // namespace