test: re-enable test-child-process-stdio-overlapped (#33502)

This commit is contained in:
Shelley Vohr 2022-03-30 12:51:13 +02:00 committed by GitHub
parent c119b1ebef
commit aac546368f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 22 additions and 3 deletions

View file

@ -674,6 +674,7 @@ step-persist-data-for-tests: &step-persist-data-for-tests
- src/out/Default/chromedriver.zip
- src/out/Default/shell_browser_ui_unittests
- src/out/Default/gen/node_headers
- src/out/Default/overlapped-checker
- src/out/ffmpeg/ffmpeg.zip
- src/electron
- src/third_party/electron_node
@ -811,6 +812,13 @@ step-mksnapshot-build: &step-mksnapshot-build
(cd out/Default; zip mksnapshot.zip mksnapshot_args gen/v8/embedded.S)
fi
step-nodejs-build-test-executable: &step-nodejs-build-test-executable
run:
name: Build Node.js Test Executables
command: |
cd src
ninja -C out/Default third_party/electron_node:overlapped-checker
step-hunspell-build: &step-hunspell-build
run:
name: hunspell build
@ -1433,6 +1441,9 @@ commands:
# Node.js headers
- *step-nodejs-headers-build
# Node.js test executable
- *step-nodejs-build-test-executable
- *step-show-goma-stats
# mksnapshot

View file

@ -7,10 +7,10 @@ This adds GN build files for Node, so we don't have to build with GYP.
diff --git a/BUILD.gn b/BUILD.gn
new file mode 100644
index 0000000000000000000000000000000000000000..bd5788caa61305fd9af8f9d7f8f1937a224fda83
index 0000000000000000000000000000000000000000..4afca42d22ee702af50da92aa08c1de897891424
--- /dev/null
+++ b/BUILD.gn
@@ -0,0 +1,394 @@
@@ -0,0 +1,403 @@
+import("//electron/build/asar.gni")
+import("//v8/gni/v8.gni")
+
@ -192,6 +192,15 @@ index 0000000000000000000000000000000000000000..bd5788caa61305fd9af8f9d7f8f1937a
+ }
+}
+
+executable("overlapped-checker") {
+ sources = []
+ if (is_win) {
+ sources += [ "test/overlapped-checker/main_win.c" ]
+ } else {
+ sources += [ "test/overlapped-checker/main_unix.c" ]
+ }
+}
+
+component("node_lib") {
+ deps = [
+ ":node_js2c",

View file

@ -4,7 +4,6 @@
"async-hooks/test-crypto-randomBytes",
"parallel/test-bootstrap-modules",
"parallel/test-child-process-fork-exec-path",
"parallel/test-child-process-stdio-overlapped",
"parallel/test-cli-node-print-help",
"parallel/test-cluster-bind-privileged-port",
"parallel/test-cluster-shared-handle-bind-privileged-port",