mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Merge pull request #11255 from electron/fix-11245

Browse source 
Enable nativeImage module addRepresentation() tests
This commit is contained in:
Zeke Sikelianos 2017-11-30 10:48:11 -08:00 • committed by GitHub
commit aab35073ee
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

13
spec/api-native-image-spec.js
View file

@ -31,7 +31,7 @@ describe('nativeImage module', () => {
width: 1
},
{
dataUrl: 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAIAAAACCAYAAABytg0kAAAAFUlEQVQYlWP8////fwYGBgYmBigAAD34BABBrq9BAAAAAElFTkSuQmCC',
dataUrl: 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAIAAAACCAIAAAD91JpzAAAAFklEQVQYlWP8//8/AwMDEwMDAwMDAwAkBgMBBMzldwAAAABJRU5ErkJggg==',
filename: '2x2.jpg',
format: ImageFormat.JPEG,
hasAlphaChannel: false,
@ -183,6 +183,7 @@ describe('nativeImage module', () => {
expect(imageFromDataUrl.getSize()).to.deep.equal(imageFromPath.getSize())
expect(imageFromDataUrl.toBitmap()).to.satisfy(
bitmap => imageFromPath.toBitmap().equals(bitmap))
expect(imageFromDataUrl.toDataURL()).to.equal(imageFromPath.toDataURL())
}
})
})
@ -193,8 +194,10 @@ describe('nativeImage module', () => {
for (const imageData of imagesData) {
const imageFromPath = nativeImage.createFromPath(imageData.path)
expect(imageFromPath.toDataURL()).to.equal(imageData.dataUrl)
expect(imageFromPath.toDataURL({scaleFactor: 2.0})).to.equal(imageData.dataUrl)
const scaleFactors = [1.0, 2.0]
for (const scaleFactor of scaleFactors) {
expect(imageFromPath.toDataURL({scaleFactor})).to.equal(imageData.dataUrl)
}
}
})
@ -444,9 +447,7 @@ describe('nativeImage module', () => {
})
})
// TODO(alexeykuzmin): Disabled during Chromium 61 upgrade.
// Fix them and enable.
xdescribe('addRepresentation()', () => {
describe('addRepresentation()', () => {
it('supports adding a buffer representation for a scale factor', () => {
const image = nativeImage.createEmpty()