mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix: gracefully fail if app.configureHostResolver is called before ready (#33062)

Browse source
This commit is contained in:
Jeremy Rose 2022-03-07 16:52:40 -08:00 committed by GitHub
parent 3d9b9b97cf
commit aa8119515f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
shell/browser/api/electron_api_app.cc
View file

@ -1630,6 +1630,11 @@ v8::Local<v8::Value> App::GetDockAPI(v8::Isolate* isolate) {
void ConfigureHostResolver(v8::Isolate* isolate, void ConfigureHostResolver(v8::Isolate* isolate,
const gin_helper::Dictionary& opts) { const gin_helper::Dictionary& opts) {
gin_helper::ErrorThrower thrower(isolate); gin_helper::ErrorThrower thrower(isolate);
if (!Browser::Get()->is_ready()) {
thrower.ThrowError(
"configureHostResolver cannot be called before the app is ready");
return;
}
net::SecureDnsMode secure_dns_mode = net::SecureDnsMode::kOff; net::SecureDnsMode secure_dns_mode = net::SecureDnsMode::kOff;
std::string default_doh_templates; std::string default_doh_templates;
if (base::FeatureList::IsEnabled(features::kDnsOverHttps)) { if (base::FeatureList::IsEnabled(features::kDnsOverHttps)) {