mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: do not use AdaptCallbackForRepeating() in electron_api_url_loader.cc (#45784)

Browse source 
refactor: do not use AdaptCallbackForRepeating in electron_api_url_loader.cc

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot] 2025-02-24 14:42:28 -06:00 • committed by GitHub
parent 24bc99cc2f
commit aa584714cd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
shell/common/api/electron_api_url_loader.cc
View file

@ -438,7 +438,7 @@ void SimpleURLLoaderWrapper::OnAuthRequired(
net::AuthCredentials(username_str, password_str)); net::AuthCredentials(username_str, password_str));
}, },
std::move(auth_responder)); std::move(auth_responder));
Emit("login", auth_info, base::AdaptCallbackForRepeating(std::move(cb))); Emit("login", auth_info, std::move(cb));
} }
void SimpleURLLoaderWrapper::OnSSLCertificateError( void SimpleURLLoaderWrapper::OnSSLCertificateError(
@ -716,8 +716,7 @@ void SimpleURLLoaderWrapper::OnDataReceived(std::string_view string_view,
v8::HandleScope handle_scope(isolate); v8::HandleScope handle_scope(isolate);
auto array_buffer = v8::ArrayBuffer::New(isolate, string_view.size()); auto array_buffer = v8::ArrayBuffer::New(isolate, string_view.size());
memcpy(array_buffer->Data(), string_view.data(), string_view.size()); memcpy(array_buffer->Data(), string_view.data(), string_view.size());
Emit("data", array_buffer, Emit("data", array_buffer, std::move(resume));
base::AdaptCallbackForRepeating(std::move(resume)));
} }
void SimpleURLLoaderWrapper::OnComplete(bool success) { void SimpleURLLoaderWrapper::OnComplete(bool success) {

1
shell/common/gin_helper/event_emitter_caller.h
View file

@ -11,6 +11,7 @@
#include "base/containers/span.h" #include "base/containers/span.h"
#include "gin/converter.h" #include "gin/converter.h"
#include "gin/wrappable.h" #include "gin/wrappable.h"
#include "shell/common/gin_converters/std_converter.h" // for ConvertToV8(iso, &&)
namespace gin_helper { namespace gin_helper {