mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: use isEqual instead of pointer equality to convert NSAppearance (#18665)

Browse source
This commit is contained in:
Samuel Attard 2019-06-07 09:55:29 -07:00 • committed by Shelley Vohr
parent b10c946564
commit a9f601612f
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
atom/browser/api/atom_api_system_preferences_mac.mm
View file

@ -66,11 +66,11 @@ struct Converter<NSAppearance*> {
return v8::Null(isolate); return v8::Null(isolate);
} }
if (val.name == NSAppearanceNameAqua) { if ([val.name isEqualToString:NSAppearanceNameAqua]) {
return mate::ConvertToV8(isolate, "light"); return mate::ConvertToV8(isolate, "light");
} }
if (@available(macOS 10.14, *)) { if (@available(macOS 10.14, *)) {
if (val.name == NSAppearanceNameDarkAqua) { if ([val.name isEqualToString:NSAppearanceNameDarkAqua]) {
return mate::ConvertToV8(isolate, "dark"); return mate::ConvertToV8(isolate, "dark");
} }
} }