mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

first attempt to add new GetParameters method to CrashReporter

Browse source
This commit is contained in:
Shelley Vohr 2017-10-31 13:06:54 -04:00
parent cd19d7c705
commit a9c13359dc
No known key found for this signature in database
GPG key ID: F13993A75599653C
4 changed files with 16 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
atom/common/api/atom_api_crash_reporter.cc
View file

@ -39,6 +39,9 @@ void RemoveExtraParameter(const std::string& key) {
CrashReporter::GetInstance()->RemoveExtraParameter(key); CrashReporter::GetInstance()->RemoveExtraParameter(key);
} }
crash_reporter::CrashReporter::StringMap GetParameters() {
return CrashReporter::GetInstance()->GetParameters();
}
void Initialize(v8::Local<v8::Object> exports, v8::Local<v8::Value> unused, void Initialize(v8::Local<v8::Object> exports, v8::Local<v8::Value> unused,
v8::Local<v8::Context> context, void* priv) { v8::Local<v8::Context> context, void* priv) {
@ -46,7 +49,8 @@ void Initialize(v8::Local<v8::Object> exports, v8::Local<v8::Value> unused,
auto reporter = base::Unretained(CrashReporter::GetInstance()); auto reporter = base::Unretained(CrashReporter::GetInstance());
dict.SetMethod("start", base::Bind(&CrashReporter::Start, reporter)); dict.SetMethod("start", base::Bind(&CrashReporter::Start, reporter));
dict.SetMethod("setExtraParameter", &SetExtraParameter); dict.SetMethod("setExtraParameter", &SetExtraParameter);
dict.SetMethod("removeExtraParameter", &SetExtraParameter); dict.SetMethod("removeExtraParameter", &RemoveExtraParameter);
dict.SetMethod("getParameters", &GetParameters);
dict.SetMethod("getUploadedReports", dict.SetMethod("getUploadedReports",
base::Bind(&CrashReporter::GetUploadedReports, reporter)); base::Bind(&CrashReporter::GetUploadedReports, reporter));
dict.SetMethod("setUploadToServer", dict.SetMethod("setUploadToServer",

11
atom/common/crash_reporter/crash_reporter.cc
View file

@ -83,14 +83,15 @@ void CrashReporter::InitBreakpad(const std::string& product_name,
bool skip_system_crash_handler) { bool skip_system_crash_handler) {
} }
void CrashReporter::SetUploadParameters() { void CrashReporter::SetUploadParameters() {}
}
void CrashReporter::SetExtraParameter(const std::string& key, void CrashReporter::SetExtraParameter(const std::string& key,
const std::string& value) { const std::string& value) {}
}
void CrashReporter::RemoveExtraParameter(const std::string& key) { void CrashReporter::RemoveExtraParameter(const std::string& key) {}
StringMap CrashReporter::GetParameters() {
return upload_parameters_;
} }
#if defined(OS_MACOSX) && defined(MAS_BUILD) #if defined(OS_MACOSX) && defined(MAS_BUILD)

1
atom/common/crash_reporter/crash_reporter.h
View file

@ -40,6 +40,7 @@ class CrashReporter {
virtual void SetExtraParameter(const std::string& key, virtual void SetExtraParameter(const std::string& key,
const std::string& value); const std::string& value);
virtual void RemoveExtraParameter(const std::string& key); virtual void RemoveExtraParameter(const std::string& key);
virtual CrashReporter::StringMap GetParameters();
protected: protected:
CrashReporter(); CrashReporter();

4
lib/common/api/crash-reporter.js
View file

@ -108,6 +108,10 @@ class CrashReporter {
setExtraParameter (key, value) { setExtraParameter (key, value) {
binding.setExtraParameter(key, value) binding.setExtraParameter(key, value)
} }
getParameters (key, value) {
binding.getParameters()
}
} }
module.exports = new CrashReporter() module.exports = new CrashReporter()