mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: fix falsy comments edge case in release notes (#16720)

Browse source
This commit is contained in:
Shelley Vohr 2019-02-04 14:57:38 -08:00 • committed by GitHub
parent af64140100
commit a9991f5451
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
script/release-notes/notes.js
View file

@ -65,9 +65,7 @@ const setPullRequest = (commit, owner, repo, number) => {
const getNoteFromClerk = async (number, owner, repo) => { const getNoteFromClerk = async (number, owner, repo) => {
const comments = await getComments(number, owner, repo) const comments = await getComments(number, owner, repo)
if (!comments && !comments.data) { if (!comments || !comments.data) return
return
}
const CLERK_LOGIN = 'release-clerk[bot]' const CLERK_LOGIN = 'release-clerk[bot]'
const PERSIST_LEAD = '**Release Notes Persisted**\n\n' const PERSIST_LEAD = '**Release Notes Persisted**\n\n'