mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

add ability to open popup on second click

Browse source
This commit is contained in:
Heilig Benedek 2017-05-20 04:21:11 +02:00
parent 4949531f57
commit a95d6b997b
2 changed files with 71 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

48
atom/renderer/atom_autofill_agent.cc
View file

@ -53,10 +53,17 @@ AutofillAgent::AutofillAgent(
content::RenderFrame* frame)
: content::RenderFrameObserver(frame),
render_frame_(frame),
helper_(new Helper(this)),
focused_node_was_last_clicked_(false),
was_focused_before_now_(false),
weak_ptr_factory_(this) {
render_frame_->GetWebFrame()->setAutofillClient(this);
}
AutofillAgent::~AutofillAgent() {
delete helper_;
}
void AutofillAgent::OnDestruct() {
delete this;
}
@ -66,6 +73,7 @@ void AutofillAgent::DidChangeScrollOffset() {
}
void AutofillAgent::FocusedNodeChanged(const blink::WebNode&) {
was_focused_before_now_ = false;
HidePopup();
}
@ -161,12 +169,17 @@ void AutofillAgent::ShowSuggestions(
ShowPopup(element, data_list_values, data_list_labels);
}
void AutofillAgent::OnAcceptSuggestion(base::string16 suggestion) {
auto element = render_frame_->GetWebFrame()->document().focusedElement();
if (element.isFormControlElement()) {
toWebInputElement(&element)->setAutofillValue(
blink::WebString::fromUTF16(suggestion));
}
AutofillAgent::Helper::Helper(AutofillAgent* agent)
: content::RenderViewObserver(agent->render_frame_->GetRenderView()),
agent_(agent) {
}
void AutofillAgent::Helper::OnMouseDown(const blink::WebNode& node) {
agent_->focused_node_was_last_clicked_ = !node.isNull() && node.focused();
}
void AutofillAgent::Helper::FocusChangeComplete() {
agent_->DoFocusChangeComplete();
}
bool AutofillAgent::OnMessageReceived(const IPC::Message& message) {
@ -204,4 +217,27 @@ void AutofillAgent::ShowPopup(
web_contents_routing_id_, routing_id(), bounds, values, labels));
}
void AutofillAgent::OnAcceptSuggestion(base::string16 suggestion) {
auto element = render_frame_->GetWebFrame()->document().focusedElement();
if (element.isFormControlElement()) {
toWebInputElement(&element)->setAutofillValue(
blink::WebString::fromUTF16(suggestion));
}
}
void AutofillAgent::DoFocusChangeComplete() {
auto element = render_frame_->GetWebFrame()->document().focusedElement();
if (element.isNull() || !element.isFormControlElement())
return;
if (focused_node_was_last_clicked_ && was_focused_before_now_) {
ShowSuggestionsOptions options;
options.autofill_on_empty_values = true;
ShowSuggestions(*toWebInputElement(&element), options);
}
was_focused_before_now_ = true;
focused_node_was_last_clicked_ = false;
}
} // namespace atom